Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configs for idle and max open connections #739

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Add configs for idle and max open connections #739

merged 9 commits into from
Jun 20, 2024

Conversation

aryanmehrotra
Copy link
Contributor

@aryanmehrotra aryanmehrotra commented Jun 20, 2024 •
edited
Loading

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

ccoVeille
ccoVeille approved these changes Jun 20, 2024
View reviewed changes
pkg/gofr/datasource/sql/sql.go Show resolved Hide resolved
pkg/gofr/datasource/sql/sql.go Outdated Show resolved Hide resolved
@ccoVeille
Copy link
Contributor

also what about supporting SetConnMaxLifetime ?

srijan-27
srijan-27 previously approved these changes Jun 20, 2024
View reviewed changes
@aryanmehrotra
Copy link
Contributor Author

screencapture-localhost-3001-docs-references-configs-2024-06-20-15_21_23

@srijan-27 srijan-27 merged commit 8d09bc1 into development Jun 20, 2024
13 checks passed
@srijan-27 srijan-27 deleted the SQL/configs branch June 20, 2024 10:47
@Umang01-hash Umang01-hash mentioned this pull request Jun 21, 2024
Merged
@srijan-27 srijan-27 mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

@vipul-rawat vipul-rawat vipul-rawat approved these changes

@srijan-27 srijan-27 srijan-27 approved these changes

@Umang01-hash Umang01-hash Umang01-hash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aryanmehrotra @ccoVeille @vipul-rawat @srijan-27 @Umang01-hash