fix add recover call in ServeHTTP

[Sianao]

Add recovery logic in the serve-http function

Description:

• recover in groutine of process Handler panic happed
• avoid a api crash avoid other api
• Closes: using file crashes in case of error #726

Checklist:

• I have formatted my code using goimport and golangci-lint.
• All new code is covered by unit tests.
• This PR does not decrease the overall code coverage.
• I have reviewed the code comments and documentation for clarity.

[aryanmehrotra]

Hey @Sianao can you describe the issue? as panic recovery is already supported by gofr.

[Sianao]

such as this one

package main

import "gofr.dev/pkg/gofr"

func main() {
	// initialise gofr object
	app := gofr.New()

	// register route greet
	app.GET("/greet", func(ctx *gofr.Context) (interface{}, error) {
		panic(nil)
		return "Hello World!", nil
	})

	// Runs the server, it will listen on the default port 8000.
	// it can be over-ridden through configs
	app.Run()
}

It will lead to the app crash。
But we don’t want other interfaces to be unavailable because of problems with one interface.
The groutine you create yourself should be responsible for its life cycle

[srijan-27]

@Sianao - have you tried running the above code locally?
As I believe it would not crash the app, but instead will return the error stack and app will continue to run.

[Sianao]

@srijan-27

this is the test result

[srijan-27]

@Sianao - Thanks! Will check this.

[Sianao]

I will rewrite the test code , because panic(nil) can't be recover on older version with nil check