Added additional logging for datasource connection #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijan-27
requested changes
May 28, 2024
|
I will work on it and fix them. |
|
Made changes according to the comments provided |
|
Can someone try to push this? If any changes are required, please let me know. |
srijan-27
previously approved these changes
Jun 6, 2024
aryanmehrotra
previously approved these changes
Jun 7, 2024
aryanmehrotra
approved these changes
Jun 7, 2024
Merged
aryanmehrotra
added a commit
that referenced
this pull request
Jun 11, 2024
* Update workflow and docs for docs deployment (#693) * Revert "Update workflow and docs for docs deployment (#693)" (#694) This reverts commit c2e022d. * Added additional logging for datasource (#655) Co-authored-by: Umang Mundhra <[email protected]> Co-authored-by: Srijan Rastogi <[email protected]> Co-authored-by: srijan-27 <[email protected]> * Fe/support for cassandra (#654) Co-authored-by: Aryan Mehrotra <[email protected]> Co-authored-by: Umang Mundhra <[email protected]> Co-authored-by: mehrotra234 <[email protected]> * Add support for local file store (#695) * add help options to display helper text for cmd applications (#661) --------- Co-authored-by: Aryan Mehrotra <[email protected]> Co-authored-by: vipul-rawat <[email protected]> * Revert request_timeout default value (#699) * upgrade framework version --------- Co-authored-by: Aryan Mehrotra <[email protected]> Co-authored-by: KedarisettiSreeVamsi <[email protected]> Co-authored-by: Umang Mundhra <[email protected]> Co-authored-by: Shashank Shekhar <[email protected]> Co-authored-by: mehrotra234 <[email protected]> Co-authored-by: Ivan APEDO <[email protected]> Co-authored-by: vipul-rawat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description:
Checklist:
goimportandgolangci-lint.Thank you for your contribution!