Set physics properties on a PhysicsMaterial. #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are properties only of Rigid and Static bodies.
Jason0214
approved these changes
Nov 16, 2020
io_scene_godot/converters/physics.py
Outdated
| phys_obj['friction'] = rbd.friction | ||
| phys_obj['bounce'] = rbd.restitution | ||
| if phys_controller != 'KinematicBody': | ||
| physics_mat = InternalResource("PhysicsMaterial") |
There was a problem hiding this comment.
IMO the resource name is still helpful here
If there is no good choice, we can just use phys_name + "PhysicsMaterial" 😊
There was a problem hiding this comment.
Will do. I think I just copied from a PhysicsMaterial I created in Godot, which is unnamed by default, but might as well give it a name if we can 👍
``` The method set_friction has been deprecated and will be removed in the future, use physics material instead. The method set_bounce has been deprecated and will be removed in the future, use physics material instead. ``` Fixes godotengine#364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364.