Add ConnOption WithDefaultSendTimeout #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a default timeout for a connection, as well as a ConnOption to set this value. If a default timeout has been set, all calls from that connection will be aborted if the timeout is exceeded. If we always want to have the same timeout for all calls from a connection, it would be easier if the timeout could be set once to the connection itself rather than always having to use CallWithContext. Change-Id: I49f34caeeace5b2cf29e56ef97f7a4817d15d158
Added a default timeout for a connection, as well as a ConnOption to set this value. If a default timeout has been set, all calls from that connection will be aborted if the timeout is exceeded unless we have specified the context. If we always want to have the same timeout for all calls from a connection, it would be easier if the timeout could be set once to the connection itself rather than always having to use CallWithContext. Change-Id: I49f34caeeace5b2cf29e56ef97f7a4817d15d158
…with-default-timeout * 'with-default-timeout' of github.com:NinniPat/dbus: Add ConnOption WithDefaultSendTimeout Change-Id: I5266c000d24ff8985f3ea9e04eda51fef64966f7
Instead of using a bool to determine if we have specified the context, we now assume that context.TODO() is only sent from functions where the user didn't specify a context. If we have context.TODO() and a default timeout we will use that to create our context and cancelFunc, otherwise we will use context.Background() or the provided context. Change-Id: I043aae124a92ba55beac0f380dc8ad3a44bbf382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default timeout for a connection, as well as a ConnOption to
set this value. If a default timeout has been set, all calls from that
connection will be aborted if the timeout is exceeded. If the context is
specified in the call, we ignore the default timeout.
If we always want to have the same timeout for all calls from a connection,
it would be easier if the timeout could be set once to the
connection itself rather than always having to use CallWithContext.