homedir: revamp #304
Merged
homedir: revamp #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in the day os/user package was relied on libc functions to parse /etc/passwd and /etc/group. This was fixed in Go 1.11 by [1] and subsequent fixes, so there is no more need to parse /etc/passwd. This assumes that users know when and how to use osusergo build tag (since this is not something very new, most are). It might make sense to note in the changelog / release notes that the static_build tag is no longer supported, and osusergo tag should be used instead. [1] https://go-review.googlesource.com/c/go/+/92456 Updates: da6051a Signed-off-by: Kir Kolyshkin <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in the day os/user package was relied on libc functions to parse
/etc/passwd and /etc/group. This was fixed in Go 1.11 by [1] and
subsequent fixes, so there is no more need to parse /etc/passwd.
This assumes that users know when and how to use osusergo build tag
(since this is not something very new, most are).
It might make sense to note in the changelog / release notes that the
static_build tag is no longer supported, and osusergo tag should be
used instead.
[1] https://go-review.googlesource.com/c/go/+/92456
Updates: da6051a