Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit parent handling #284

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Fix commit parent handling #284

merged 4 commits into from
Nov 15, 2021

Conversation

rbailey-godaddy
Copy link
Contributor

@rbailey-godaddy rbailey-godaddy commented Nov 15, 2021 •
edited
Loading

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

What's new?

  • Correctly handle case when scan reaches head commit of local repository (which has no parents)

@rscottbailey
Fix typo
089374a 
Without this fix, we don't catch the exception at the first commit (with
no parents) and we dump instead of completing the final step of the
scan.
@rscottbailey
Fix handler more
92cdbe0 
And document why we're catching what we're catching
@rbailey-godaddy rbailey-godaddy requested a review from a team as a code owner November 15, 2021 17:14
@rbailey-godaddy rbailey-godaddy changed the base branch from main to v3.x November 15, 2021 17:16
@tarkatronic tarkatronic merged commit 63eabca into v3.x Nov 15, 2021
@tarkatronic tarkatronic deleted the typo branch November 15, 2021 17:34
@pmevzek-godaddy pmevzek-godaddy mentioned this pull request Apr 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarkatronic tarkatronic tarkatronic approved these changes

@djlarsu djlarsu Awaiting requested review from djlarsu djlarsu is a code owner automatically assigned from godaddy/tartufo

@beardedeagle beardedeagle Awaiting requested review from beardedeagle beardedeagle is a code owner automatically assigned from godaddy/tartufo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbailey-godaddy @tarkatronic @rscottbailey