Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick-off the rust #27

Merged
merged 29 commits into from
Feb 13, 2020
Merged

Kick-off the rust #27

merged 29 commits into from
Feb 13, 2020

Conversation

kquerna
Copy link
Collaborator

@kquerna kquerna commented Jan 31, 2020

Updating portions of package to accommodate:

  • added sprint and epic function 'status' for sprint reporting on epics
  • support basic auth in addition to cookie based auth
  • added debug logging with diagnostics
  • added plumbing for query string params to makeGetRequests

bin/cli.js Show resolved Hide resolved
bin/cli.js Outdated Show resolved Hide resolved
src/epic.actions.js Outdated Show resolved Hide resolved
src/epics.actions.js Show resolved Hide resolved
src/epics.actions.js Outdated Show resolved Hide resolved
src/sprint.actions.js Outdated Show resolved Hide resolved
src/sprint.actions.js Outdated Show resolved Hide resolved
src/sprint.actions.js Outdated Show resolved Hide resolved
src/sprints.actions.js Outdated Show resolved Hide resolved
src/sprints.actions.js Outdated Show resolved Hide resolved
Copy link
Contributor

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Might have a few duplicate comments from @msluther since I started this review earlier today.

bin/cli.js Outdated Show resolved Hide resolved
src/epic.actions.js Outdated Show resolved Hide resolved
src/epic.actions.js Outdated Show resolved Hide resolved
src/formatters/index.js Outdated Show resolved Hide resolved
src/formatters/index.js Outdated Show resolved Hide resolved
src/sprints.actions.js Outdated Show resolved Hide resolved
src/sprints.actions.js Outdated Show resolved Hide resolved
src/jira-client.js Show resolved Hide resolved
src/jira-client.js Show resolved Hide resolved
src/jira-client.js Show resolved Hide resolved
src/epic.actions.js Outdated Show resolved Hide resolved
@msluther
Copy link

msluther commented Feb 7, 2020

Could you also please update the package.json to add in the lint script to run on tests like so:

  "scripts": {
    "lint": "eslint --config .eslintrc.js --fix src/ test/ bin/",
+    "posttest": "npm run lint",
    "test": "npm run lint && mocha --recursive",
    "uninstall": "./bin/cli.js uninstall-completion"
  },

That way we're sure linting is being run and failures will also fail the test run.

src/jira-client.js Outdated Show resolved Hide resolved
Copy link
Contributor

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the note on authmode is worth discussing. Perhaps we can pair on it together to get over the finish line?

src/jira-client.js Outdated Show resolved Hide resolved
@indexzero indexzero merged commit f14da4c into master Feb 13, 2020
@indexzero indexzero deleted the fix-it branch February 13, 2020 01:05
@kquerna kquerna mentioned this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants