-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kick-off the rust #27
Conversation
[dist fix] Use 'make-promises-safe'
…(Epic, Story, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Might have a few duplicate comments from @msluther since I started this review earlier today.
Could you also please update the "scripts": {
"lint": "eslint --config .eslintrc.js --fix src/ test/ bin/",
+ "posttest": "npm run lint",
"test": "npm run lint && mocha --recursive",
"uninstall": "./bin/cli.js uninstall-completion"
}, That way we're sure linting is being run and failures will also fail the test run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the note on authmode
is worth discussing. Perhaps we can pair on it together to get over the finish line?
…indexzero from TODO comments, so anyone can pick up the work
Updating portions of package to accommodate: