-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALL: Make dependencies optional where possible #36
Labels
enhancement
New feature or request
Comments
jpaskhay
added a commit
that referenced
this issue
Jul 8, 2019
- initial implementation of using optional dependencies for #36 - not ready for PR yet. we should verify this is the right approach. just wanted to push up local changes for reference - reference apps and test app show the approach end users would need to pull in dependencies they'd want - still need documentation changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All dependencies are currently required in existing language implementations (Java and C# as of this writing). For example, if someone uses the RDBMS metastore implementation, the SDK will still pull in the AWS DynamoDB SDK and all its transitive dependencies.
We can make pluggable external integrations and optional features only use optional dependencies so the user doesn't have to pull in dependency chains for unused parts.
An alternative approach we had discussed a while back was breaking out the external dependencies into separate projects/modules. The optional dependency approach seems like it will have less overhead in the SDK repo itself, and it shouldn't have much of a negative impact from an end user perspective.
Can discuss which approach seems best. Regardless of which approach is taken, we'll need to update documentation accordingly.
The text was updated successfully, but these errors were encountered: