Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logging transactionHash if a transaction failed + timeout in seconds #261

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Added logging transactionHash if a transaction failed + timeout in seconds #261

merged 4 commits into from
Apr 19, 2022

Conversation

devedse
Copy link
Contributor

@devedse devedse commented Apr 18, 2022 •
edited
Loading

This PR adds:

  • Logging the transactionHash when a transaction fails
  • --timeout flag to provide a timeout when waiting for transactions

@devedse
Copy link
Contributor Author

devedse commented Apr 18, 2022

I'm not sure if this is the right way to do this, but it might be a good start :).

@devedse devedse mentioned this pull request Apr 18, 2022
Open
@devedse devedse changed the title Added logging transactionHash if a transaction failed Added logging transactionHash if a transaction failed + timeout in seconds Apr 18, 2022
@treeder treeder requested a review from r-gochain April 19, 2022 17:33
@r-gochain r-gochain merged commit 2cd28f2 into gochain:master Apr 19, 2022
@devedse
Copy link
Contributor Author

devedse commented Apr 19, 2022

Seems the build is failing at quite a few places.
I'm not a GO developer at all so I didn't really test anything. 🙂

@r-gochain
Copy link
Contributor

I'm fixing

@devedse
Copy link
Contributor Author

devedse commented Apr 19, 2022

Sorry for the oopses :(

@r-gochain r-gochain mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-gochain r-gochain r-gochain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devedse @r-gochain