add cidByHash #15
Merged
add cidByHash #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
cidByHashmapping, which storeskeccak256(CID)toCID. This enables linking emitted events to input CIDs, since the events only hold the hash. Previously, we were parsing the tx inputs to get the original CID, but that only works for external calls to pin and not for deposit wallets or any other contracts that could call us directly. Instead, we can look up the CID from the map on the contract, which will work reliably and consistently for any emitted Pinned event, no matter how it was produced.gofs.solandGOFS.jsare the only real changes - the rest is generated.