Tests and Wallets #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
tests-wallets
branch
6 times, most recently
from
81c3c6b
to
bd462ef
Compare
r-gochain
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds deposit wallets (#8) and truffle tests (#2), and does a bunch of general cleanup.
By bundling the wallet contract management in to the main contract, we can simplify deploying for users (just call a func instead of deploying manually) and keep a central map of one wallet contract per cid. The current gas used create a new wallet is
226935.The
gofscommand can fetch a wallet address, and create a new one if none exists: