Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework wallet page #440

Open
3 of 7 tasks
treeder opened this issue Oct 30, 2019 · 3 comments
Open
3 of 7 tasks

Rework wallet page #440

treeder opened this issue Oct 30, 2019 · 3 comments
Assignees

Comments

@treeder
Copy link
Contributor

treeder commented Oct 30, 2019

The idea is to make it simpler and more usable. Right now it takes many clicks to get the point of sending a transaction when it could all just be one simple form. Also, forcing user to enter private key first makes it annoying when you want to enter the to and amount before entering the private key.

Phase 1

  • Drop 'owned tokens' tab (can already find on address page)
  • Drop 'transactions' tab (can already find on address page)
  • Drop 'use contract' tab (can already interact from contract page)
  • Make hex address a link to address page

Phase 2

  • Drop all tabs
  • Show one single form with everything in it to send or deploy a contract
  • After private key is entered, show balance near the field (can enter PK at any time) - metamask will show balance in the metamask popup so we probably don't need to show it for MM. But if we can show it easily, then let's do that.
@jmank88
Copy link
Contributor

jmank88 commented Oct 31, 2019

I reorganized things in to two parts. Phase 1 can be added pretty easily to #430 now. After that, we could merge and do phase 2 separately (which requires more reworking of the UI layout). @brockmcblockchain could you post the latest mock-up for the desired form layout?

@brockmcblockchain
Copy link
Contributor

Rough Mocks from our previous chats.

Screen Shot 2019-10-30 at 10 41 32 AM
Screen Shot 2019-10-30 at 10 27 43 AM

bergauz added a commit that referenced this issue Jan 20, 2020
@treeder
Copy link
Contributor Author

treeder commented Jan 22, 2020

Wonder if it would be useful to save the private key in session storage (until they close the tab) so they can browse around, use contracts, use the wallet, etc. until they are done? Or too insecure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants