Fixed ParseBytes and ParseFile by adding agclearerrors in C
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denk0403
changed the title
denk0403
changed the title
agclearerrors in C
|
Thank you for your contribution ! I've commented |
|
The tests should pass for Go version 1.15 now! |
goccy
reviewed
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the bug described by issue #60.
In summary, this PR introduces
agclearerrors()in the C code, which closes and resets the output file for error reporting. In theccallpackage, a binding is created viaAgclearerrors()function.ParseBytes()andParseFile()in thecgraphpackage now callAgclearerrors()before reading and parsing the buffer to ensure there are no extraneous errors left over, and that the call toAglasterr()returns only new errors produced by parsing.