Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separated e2e test to remove test-only/circular module dependency to pop #135

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Jul 9, 2022

Separated e2e test to remove test-only/circular module dependency to pop.

The circular dependency was introduced by #94 and it made fizz hard to manage its module dependency. Checking if this workaround works.

The dependency graph of the previous versions:

fizz-v1 14 0
fizz-v1 14 1

It will become:

fizz-20220709-202743

Some checking points on this e2e test:

  • the test is a static test without any autogenerated files during the test
    • in most situation, I guess the test result will be the same every runs if the developer did not regenerate migrations
    • so it does not work as a gatekeeper
  • not sure if fizz is a good place for the e2e test.

@sio4 sio4 self-assigned this Jul 9, 2022
@sio4 sio4 added dependency update module dependencies internal cleanup internal cleanup (or a kind of refactoring) labels Jul 9, 2022
@sio4 sio4 merged commit 59bc255 into main Jul 9, 2022
@sio4 sio4 deleted the separating-e2e-test branch July 9, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency update module dependencies internal cleanup internal cleanup (or a kind of refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant