Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

add logger of session #1283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add logger of session #1283

wants to merge 2 commits into from

Conversation

chenxuey
Copy link

每个 session 也可以注入一个日志

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #1283 into master will decrease coverage by 0.06%.
The diff coverage is 36.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
- Coverage   57.36%   57.29%   -0.07%     
==========================================
  Files          44       44              
  Lines        7817     7824       +7     
==========================================
- Hits         4484     4483       -1     
- Misses       2777     2783       +6     
- Partials      556      558       +2
Impacted Files Coverage Δ
session_convert.go 22.29% <0%> (ø) ⬆️
session_get.go 75.83% <100%> (ø) ⬆️
session_context.go 75% <100%> (ø) ⬆️
session_delete.go 58.22% <100%> (ø) ⬆️
session_schema.go 59.12% <100%> (ø) ⬆️
session_insert.go 56.84% <14.28%> (ø) ⬆️
session_update.go 56.44% <18.18%> (ø) ⬆️
session.go 57.9% <25%> (-0.59%) ⬇️
session_raw.go 57.57% <50%> (ø) ⬆️
session_find.go 67.91% <62.5%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce804ae...6e1a08b. Read the comment docs.

@BetaCat0
Copy link
Member

Please add some tests for this change :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants