This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Implementing elseif for conversion of Default #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit the Default would be reset to 0 every time it is not true. This results in an issue when true is converted to 1 and 1 is not true, resulting in a conversion to 0. Signed-off-by: Christopher Dziomba <[email protected]>
lunny
approved these changes
Dec 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 54.7% 54.69% -0.02%
==========================================
Files 42 42
Lines 7646 7646
==========================================
- Hits 4183 4182 -1
Misses 2935 2935
- Partials 528 529 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 54.7% 54.69% -0.02%
==========================================
Files 42 42
Lines 7646 7646
==========================================
- Hits 4183 4182 -1
Misses 2935 2935
- Partials 528 529 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the Default would be reset to 0 every time it is not true. This results in an issue when true is converted to 1 and 1 is not true, resulting in a conversion to 0.
This should also fix go-gitea/gitea#4282.