Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): user entity id not encoded correctly #98

Merged
merged 4 commits into from
Jan 28, 2023
Merged

fix(protocol): user entity id not encoded correctly #98

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20a2230
fix(protocol): user entity id not encoded correctly
james-d-elliott Jan 27, 2023
dca17a6
docs: update issue template
james-d-elliott Jan 27, 2023
e81bba6
Merge branch 'master' into fix-entity-url-encoding
james-d-elliott Jan 27, 2023
55cffa4
test: fix test nuance
james-d-elliott Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(protocol): user entity id not encoded correctly 
This fixes an issue where the protocol.UserEntity field ID was encoded with Base64 URL Encoding with padding instead of without padding.
  • Loading branch information
@james-d-elliott
james-d-elliott committed Jan 27, 2023
commit 20a2230ad811771d97b841dbccd57aa72eb1aa7a
2 changes: 1 addition & 1 deletion protocol/entities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ type UserEntity struct {
// authentication and authorization decisions MUST be made on the basis of this id
// member, not the displayName nor name members. See Section 6.1 of
// [RFC8266](https://www.w3.org/TR/webauthn/#biblio-rfc8266).
ID []byte `json:"id"`
ID URLEncodedBase64 `json:"id"`
}