Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat protocol implement device eligible and backup flags + added authentication transportation hybrid #75

Closed
wants to merge 3 commits into from

Conversation

naetraga
Copy link
Contributor

Solves #74 and add backup flags to authenticator flags

naetraga and others added 3 commits November 30, 2022 13:21
extended AuthenticatorTransport type with new hybrid value incl. description from official documentation

Fixes go-webauthn#74
Extend existing flags by adding new ones backup eligible and backup state
feat protocol: added authentication transportation hybrid
@naetraga naetraga requested a review from a team as a code owner November 30, 2022 13:57
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also split these changes into separate PRs.

@@ -99,6 +99,8 @@ const (
BLE AuthenticatorTransport = "ble"
// Internal the client should use an internal source like a TPM or SE
Internal AuthenticatorTransport = "internal"
// HYBRID indicates the respective authenticator can be contacted using a combination of (often separate) data-transport and proximity mechanisms. This supports, for example, authentication on a desktop computer using a smartphone.
HYBRID AuthenticatorTransport = "hybrid"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HYBRID AuthenticatorTransport = "hybrid"
Hybrid AuthenticatorTransport = "hybrid"

james-d-elliott added a commit that referenced this pull request Dec 7, 2022
Extend existing flags by adding new ones backup eligible and backup state.

Closes #75

Co-authored-by: Tobias Albrecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants