test(protocol): add coverage to 256bit ecdsa curve #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[this repost of https://github.com/duo-labs/webauthn/pull/158, after seeing https://github.com/duo-labs/webauthn/issues/155]
For a few hours I was convinced that this library (
webauthncose
package specifically) wasn't doing its job properly because my code was accepting bad signatures as valid. So I set out to write a test to capture this. Turns out: this library is doing its job, and my code was at fault!Shameful details
The bug in the above snippet:
errors.Wrap(nil, "something")
isnil
. Which means whenvalid
isfalse
,nil
is returned 🤦Instead of discarding this test I thought it'd be a good addition to the test suite.