Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect usage of subtle #7

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix: incorrect usage of subtle #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: incorrect usage of subtle 
This fixes an incorrect usage of subtle.ConstantTimeCompare.
  • Loading branch information
@james-d-elliott
james-d-elliott committed Mar 1, 2022
commit 15a6664c03eb6ae9dbfc8e350cb6213dc747dbf3
2 changes: 1 addition & 1 deletion protocol/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (c *CollectedClientData) Verify(storedChallenge string, ceremony CeremonyTy
// passed to the get() call.

challenge := c.Challenge
if subtle.ConstantTimeCompare([]byte(storedChallenge), []byte(challenge)) == 1 {
if subtle.ConstantTimeCompare([]byte(storedChallenge), []byte(challenge)) != 1 {
err := ErrVerification.WithDetails("Error validating challenge")
return err.WithInfo(fmt.Sprintf("Expected b Value: %#v\nReceived b: %#v\n", storedChallenge, challenge))
}
Expand Down