Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: backup flag validation #240

Merged
merged 4 commits into from
May 28, 2024
Merged

feat!: backup flag validation #240

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7b3962
Ensure BackupEligible flag consistency during login validation
May 25, 2024
0254b23
fix return message
May 25, 2024
e5f2d81
Ensure BackupEligible and BackupState flag consistency during login v…
May 25, 2024
3b76dbf
Merge branch 'master' into fix/ensure-backup-eligible-flag-consistency
zahraKeshtkar May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion webauthn/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,16 @@ func (webauthn *WebAuthn) validateLogin(user User, session SessionData, parsedRe

// Handle step 17.
loginCredential.Authenticator.UpdateCounter(parsedResponse.Response.AuthenticatorData.Counter)
// Check if the BackupEligible flag has changed.
if loginCredential.Flags.BackupEligible != parsedResponse.Response.AuthenticatorData.Flags.HasBackupEligible() {
return nil, protocol.ErrBadRequest.WithDetails("BackupEligible flag inconsistency detected during login validation")
}

// Check for the invalid combination BE=0 and BS=1.
if !parsedResponse.Response.AuthenticatorData.Flags.HasBackupEligible() && parsedResponse.Response.AuthenticatorData.Flags.HasBackupState() {
return nil, protocol.ErrBadRequest.WithDetails("Invalid flag combination: BE=0 and BS=1")
}

// TODO: The backup eligible flag shouldn't change. Should decide if we want to error if it does.
// Update flags from response data.
loginCredential.Flags.UserPresent = parsedResponse.Response.AuthenticatorData.Flags.HasUserPresent()
loginCredential.Flags.UserVerified = parsedResponse.Response.AuthenticatorData.Flags.HasUserVerified()
Expand Down