Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: master to v0.1 #19

Merged
merged 2 commits into from
Mar 1, 2022
Merged

backport: master to v0.1 #19

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd0c65
fix: unused json tag (#17)
james-d-elliott Mar 1, 2022
35287ea
fix: check the credential id length att data (#16)
james-d-elliott Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: unused json tag (#17) 
The struct in question is used internally not for unmarshalling JSON (i.e. post parsing the JSON struct).
  • Loading branch information
@james-d-elliott
james-d-elliott committed Mar 1, 2022
commit dfd0c651a3739da798bb1b038078cb4425d4caf7
2 changes: 1 addition & 1 deletion protocol/credential.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ type CredentialCreationResponse struct {
type ParsedCredentialCreationData struct {
ParsedPublicKeyCredential
Response ParsedAttestationResponse
Transports []AuthenticatorTransport
Raw CredentialCreationResponse
Transports []AuthenticatorTransport `json:"transports,omitempty"`
}

func ParseCredentialCreationResponse(response *http.Request) (*ParsedCredentialCreationData, error) {
Expand Down