fix: timeout config not propagating #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout config for registration when using User Verification Discouraged was not set correctly.
|
Maybe a test case (to guard against regression) would be useful here. :-) |
|
Thanks for the suggestion, likely something we'll add once we're looking to stabilize and/or work towards OpenSSF BP. I have quite a few tests that need to be added here after my inheritance of this project and the lack of testing for this function makes that very clear in this instance so I'll pick it up in the near future (or someone else would be welcome to). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout config for registration when using User Verification Discouraged was not set correctly.
Fixes #187