Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to jwt v5 #152

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

CoreFloDev
Copy link
Contributor

Hi,

I did the migration do jwtv5 there wasn't much to do as the repo doesn't use methods that have been refactored

Have a look at https://github.com/golang-jwt/jwt/releases/tag/v5.0.0 if you want more details on the changes

Thanks

@CoreFloDev CoreFloDev requested a review from a team as a code owner July 7, 2023 11:59
@CoreFloDev CoreFloDev force-pushed the feat/migrate-to-jwtv5 branch 3 times, most recently from dc5005a to 66e283d Compare July 7, 2023 12:28
Signed-off-by: CoreFloDev <[email protected]>

Signed-off-by: “CoreFloDev” <“[email protected]”>
@CoreFloDev
Copy link
Contributor Author

I did the required changes for the DCO, it doesn't seems to work I don't get why. Anyway, this PR should close #136 as well

Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoreFloDev
Copy link
Contributor Author

Nice! I don't have merge right so I let you do it 😄

@james-d-elliott james-d-elliott merged commit 9cb3504 into go-webauthn:master Jul 18, 2023
4 checks passed
@CoreFloDev CoreFloDev deleted the feat/migrate-to-jwtv5 branch July 19, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants