Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): expose ccr/car parse method #128

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

james-d-elliott
Copy link
Member

This fixes inaccessibility to parsing protocol.CredentialCreationResponse / protocol.CredentialAssertionResponse into a protocol.ParsedCredentialCreationData / protocol.ParsedCredentialAssertionData object which may prevent the use of the library with gRPC for example.

This fixes inaccessibility to parsing protocol.CredentialCreationResponse / protocol.CredentialAssertionResponse into a protocol.ParsedCredentialCreationData / protocol.ParsedCredentialAssertionData object which may prevent the use of the library with gRPC for example.
@james-d-elliott james-d-elliott requested a review from a team as a code owner February 21, 2023 23:12
Copy link

@isgj isgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks nice, Thanks

@james-d-elliott james-d-elliott merged commit 709be4f into master Feb 22, 2023
@james-d-elliott james-d-elliott deleted the fix-expose-ccr-validations branch February 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants