fix(protocol): missing attachment field #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transports JSON path as far as the Webauthn level 3 spec is concerned is response.transports i.e. within the response object with response.clientDataJSON and response.attestationObject. This fixes this location and allows for backwards temporary compatibility for anyone implementing the previous method. See the typedef https://w3c.github.io/webauthn/#typedefdef-publickeycredentialjson for more information.
The authenticatorAttachment field was missing previously from the PublicKeyCredentialJSON. This fixes it and includes it as part of the Credential during registration. See typedef https://w3c.github.io/webauthn/#typedefdef-publickeycredentialjson for more information.
# Conflicts: # protocol/assertion.go # protocol/credential.go # protocol/credential_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authenticatorAttachment field was missing previously from the PublicKeyCredentialJSON. This fixes it and includes it as part of the Credential during registration. See typedef https://w3c.github.io/webauthn/#typedefdef-publickeycredentialjson for more information.