Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AttestationConveyancePreference enterprise support #90

Closed
hochhaus opened this issue Dec 29, 2022 · 2 comments · Fixed by #100
Closed

Add AttestationConveyancePreference enterprise support #90

hochhaus opened this issue Dec 29, 2022 · 2 comments · Fixed by #100
Labels
status/needs-triage Issues that need to be triaged. type/feature-request Feature Requests

Comments

@hochhaus
Copy link

Description

It would be nice if this library added support for enterprise attestation

Use Case

For enterprise deployments (where all hardware and configurations and centrally maintained) it would be nice to be able to request enterprise attestation.

Documentation

https://www.w3.org/TR/webauthn-2/#enum-attestation-convey

https://www.w3.org/TR/webauthn-2/#dom-attestationconveyancepreference-enterprise

https://groups.google.com/a/fidoalliance.org/g/fido-dev/c/TdCoQUsgFZU?pli=1

@hochhaus hochhaus added status/needs-triage Issues that need to be triaged. type/feature-request Feature Requests labels Dec 29, 2022
@james-d-elliott
Copy link
Member

As far as I can tell the only implementation detail for RP's is the enum value "enterprise". If that's literally all then we can implement it relatively easily.

If there are some additional requirements or information in the attStmt we'd need to see those specific specs. If it's something that differs on browsers, devices, etc we'd need to have a way for the implementer to do specific validations.

@hochhaus
Copy link
Author

Thanks @james-d-elliott.

As far as I can tell the only implementation detail for RP's is the enum value "enterprise". If that's literally all then we can implement it relatively easil

As best I can tell at the moment, adding the enum value and treating it otherwise as direct is likely enough.

I'm still new to the spec though so I could be missing something.

james-d-elliott added a commit that referenced this issue Jan 29, 2023
This adds the enterprise value for attestation preferences as well as improves the documentation of this section.

Closes #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/needs-triage Issues that need to be triaged. type/feature-request Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants