Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify topOrigin #205

Closed
jameshartig opened this issue Jan 19, 2024 · 2 comments · Fixed by #217
Closed

Verify topOrigin #205

jameshartig opened this issue Jan 19, 2024 · 2 comments · Fixed by #217
Labels
status/needs-triage Issues that need to be triaged. type/feature-request Feature Requests

Comments

@jameshartig
Copy link

Description

The latest draft discusses verifying topOrigin along with origin. Right now this library only validates origin. Maybe an RPTopOrigins field could be added to Config, though this means the default would be to not allow any topOrigin value which might not be backwards-compatible. It also wouldn't be easy for an RP to allow any topOrigin value. Maybe instead it could be some sort of enum like AllowAll, AllowRPOrigins, AllowNone, but then you couldn't specify third-party ones.

Use Case

Our particular use-case is that we don't allow any topOrigin value, but longer-term we might want to allow our top-level domain as a valid topOrigin.

Documentation

See w3c/webauthn#1891 and https://w3c.github.io/webauthn/#sctn-validating-origin.

@jameshartig jameshartig added status/needs-triage Issues that need to be triaged. type/feature-request Feature Requests labels Jan 19, 2024
@james-d-elliott
Copy link
Member

I'll have a think about how to implement this. I think it's probably fine to implement it as an opt in to be decided by the RP until it's no longer a draft or to make it part of the level 3 wait-list depending on how urgent it is for users of the lib.

@jameshartig
Copy link
Author

I'll have a think about how to implement this. I think it's probably fine to implement it as an opt in to be decided by the RP until it's no longer a draft or to make it part of the level 3 wait-list depending on how urgent it is for users of the lib.

I think it's fine for it to be on the wait-list. I mostly filed this so it wouldn't be forgotten about.

james-d-elliott added a commit that referenced this issue Apr 26, 2024
This adds top origin verification options to the library.

Closes #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/needs-triage Issues that need to be triaged. type/feature-request Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants