Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List issues and PRs from upstream that got resolved here #2

Closed
mainrs opened this issue Jan 11, 2022 · 2 comments
Closed

List issues and PRs from upstream that got resolved here #2

mainrs opened this issue Jan 11, 2022 · 2 comments

Comments

@mainrs
Copy link

mainrs commented Jan 11, 2022

It would be nice to have such a list to see what has been fixed and what not. A simple list with cross-reference would be enough I guess. :)

Just noticed that there is even a second fork you work on as well: https://github.com/authelia/webauthn
Could you explain which one is the most up-to-date? Seems like you actively contribute to all of them @james-d-elliott :D

@james-d-elliott
Copy link
Member

james-d-elliott commented Feb 24, 2022

Sorry for not replying earlier, been a busy time for me this year. Makes sense to me. I can work on this.

I mainly setup the github.com/authelia/webauthn lib for rapid development of Authelia's webauthn implementation. It is the most up to date with duo's lib, and has more features implemented.

I was intending to set this fork up instead of using github.com/authelia/webauthn so there was a community fork with more stability since duo seemed to lack interest in keeping the project maintained. I'm not entirely sure if I will continue since duo seemed to start maintaining it but if there is interest I can.

I will definitely consider taking it up if duo doesn't meet my expectations, or with a lot of public interest.

james-d-elliott added a commit that referenced this issue Mar 1, 2022
This relates to #2 and adds a section detailing the differences between this library and the upstream library.
james-d-elliott added a commit that referenced this issue Mar 1, 2022
This relates to #2 and adds a section detailing the differences between this library and the upstream library.
james-d-elliott added a commit that referenced this issue Mar 1, 2022
This relates to #2 and adds a section detailing the differences between this library and the upstream library.
james-d-elliott added a commit that referenced this issue Mar 1, 2022
This relates to #2 and adds a section detailing the differences between this library and the upstream library.
@james-d-elliott
Copy link
Member

james-d-elliott commented Mar 1, 2022

@mainrs I've compiled the list in the linked PR/Commits. Unfortunately GitHub markdown doesn't automatically link to commit sha's, so I'll have to fix it up later, but all the information is documented. I'll leave this open for anyone else who's interested.

Edit: Also sorry again, didn't see this notification in the sea of notifications and was too busy to clear my list over the last few months. I'll keep a closer eye on this repository though. :)

@james-d-elliott james-d-elliott pinned this issue Mar 1, 2022
@james-d-elliott james-d-elliott unpinned this issue Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants