Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON struct tags to Credential #197

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add JSON struct tags to Credential #197

merged 1 commit into from
Dec 20, 2023

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Dec 3, 2023

Fixes #193.

@mitar mitar requested a review from a team as a code owner December 3, 2023 09:29
james-d-elliott
james-d-elliott approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott merged commit 99b2e0d into go-webauthn:master Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-d-elliott james-d-elliott james-d-elliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credential struct should have json struct tags
2 participants
@mitar @james-d-elliott