-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credential struct should have json struct tags #193
Comments
I can likely add this in v0.10.0. It's technically a breaking change but as we're v0 we can probably afford to and people can just copy the old struct as an intermediary if they have issues. Not sure golang's json library has any tooling specifically to handle this situation. |
So golang json library in fact ignores JSON field case (which is what I primarily would want to achieve with struct tags). So adding json struct tags should just make new JSON have new case, but it would continue to parse old ones. So if somebody did already marshal credentials they will be able to continue use those.
Only if they marshal credentials and parse them with some other tool they might have a problem. |
Description
It seems one has to persist credentials. One easy way to do so would be to store them as JSON. But corresponding JSON is ugly because
Credential
does not have json struct tags.Use Case
No response
Documentation
No response
The text was updated successfully, but these errors were encountered: