Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the server broker the connection forcefully, the client should disconnect #2

Merged
merged 1 commit into from
Aug 23, 2014

Conversation

joliver
Copy link

@joliver joliver commented Aug 23, 2014

RabbitMQ can forcefully close the connection. When this happens the client doesn't correctly perform any shutdown behavior.

When the error frame is received, the length of the channels slice is 0, so nothing is ever signaled of the failure.

@jjeffery
Copy link
Member

Thanks for the contribution. It would be nice to include a test, although I acknowledge that the test coverage for the client code is not extensive as it is.

jjeffery added a commit that referenced this pull request Aug 23, 2014
When the server broker the connection forcefully, the client should disconnect
@jjeffery jjeffery merged commit f9009d7 into go-stomp:master Aug 23, 2014
@joliver
Copy link
Author

joliver commented Aug 23, 2014

In looking through the source code, I'm thinking there are a lot more places where low-level TCP connectivity problems could cause a deadlock to occur (e.g. writing to a closed channel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants