pass unsigned int as it is without converting it to string #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statement.go
Outdated
| @@ -169,7 +168,7 @@ func (c converter) ConvertValue(v interface{}) (driver.Value, error) { | |||
| case reflect.Uint64: | |||
| u64 := rv.Uint() | |||
| if u64 >= 1<<63 { | |||
There was a problem hiding this comment.
Is there any reason to still do this check for the high bit instead of just always returning u64?
|
It seems like this doesn't work with Go 1.8: https://travis-ci.org/go-sql-driver/mysql/jobs/405365785#L607 |
|
Regarding the building error, Let's hold this until we drop 1.8 support? |
|
@darren Would you update this PR? We don't support Go 1.8 anymore. |
|
@methane I have tested against MySQL and TiDB, TiDB still got the unsigned bigint thing wrong in corner cases, I shall report again to TiDB once this PR get merged. |
methane
approved these changes
Apr 5, 2019
|
Thank you. |
vmg
added a commit
to vmg/mysql
that referenced
this pull request
Apr 23, 2019
PR go-sql-driver#838 introduced a fix for the driver's custom Value Converter that stopped emitting large uint64 `driver.Value`s as a string. Instead, now _all_ uint{8,16,32,64} values passed to the driver are returned as uint64, and `packets.c` now explicitly handles `driver.Value` instances that are uint64. However, the update in `packets.c` only applies when sending `driver.Value` arguments to the server. When a connection is set up using `InterpolateParams = true` and query interpolation happens inside of the driver, the `(*mysqlConn) interpolateParams` does **not** handle uint64 values (which, again, are now passed by `database/sql` because we've updated our value converter to generate them). Because of this, any `DB.Query` operations which have an uint argument (regardless of its size!!) will force the driver to return `driver.ErrSkip`, disabling client interpolation for such queries. We can fix this by updating `interpolateParams` like we previously updated `writeExecutePacket`.
5 tasks
julienschmidt
pushed a commit
that referenced
this pull request
Apr 23, 2019
PR #838 introduced a fix for the driver's custom Value Converter that stopped emitting large uint64 `driver.Value`s as a string. Instead, now _all_ uint{8,16,32,64} values passed to the driver are returned as uint64, and `packets.c` now explicitly handles `driver.Value` instances that are uint64. However, the update in `packets.c` only applies when sending `driver.Value` arguments to the server. When a connection is set up using `InterpolateParams = true` and query interpolation happens inside of the driver, the `(*mysqlConn) interpolateParams` does **not** handle uint64 values (which, again, are now passed by `database/sql` because we've updated our value converter to generate them). Because of this, any `DB.Query` operations which have an uint argument (regardless of its size!!) will force the driver to return `driver.ErrSkip`, disabling client interpolation for such queries. We can fix this by updating `interpolateParams` like we previously updated `writeExecutePacket`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it is not necessary to convert uint64 to string
related issue: pingcap/tidb#7089
Checklist