Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with latest Go patch versions #693

Merged
merged 2 commits into from
Jan 10, 2018

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Oct 27, 2017

No description provided.

@julienschmidt
Copy link
Member

Isn't that doing exactly the same as before?
tip is the master branch, and 1.x should download the latest minor version already.

@AlekSi
Copy link
Contributor Author

AlekSi commented Oct 27, 2017

tip is the master branch

Yes, but gimme now uses master instead of tip for consistency. Mercurial days are long gone. 😄

and 1.x should download the latest minor version already.

If you mean latest patch version, then, unfortunately, no – 1.9 will install 1.9.

@julienschmidt
Copy link
Member

Looks like I'm wrong. The output of our Travis builds doesn't indicate any minor revisions (1.x.x ). See e.g. https://travis-ci.org/go-sql-driver/mysql/jobs/289160333, which should use 1.5.4
The management of Go versions on Travis seems to have changed quite a bit since we started using it 😄

@AlekSi
Copy link
Contributor Author

AlekSi commented Oct 27, 2017

Yes, it is split between gimme and travis-build repos in a confusing way.

@julienschmidt
Copy link
Member

For some reason go 1.5.4 doesn't seem to be able to import golang.org/x/tools/cmd/cover while go 1.5 did: https://travis-ci.org/go-sql-driver/mysql/jobs/293776591

@julienschmidt
Copy link
Member

However, I think we agreed somewhere, that we only support the last 4 (or was it even 3?) versions of Go, so dropping Go 1.5 support should be fine.
We should document that e.g. in the Wiki.

@julienschmidt
Copy link
Member

Let's see what the other guys say... #696

@julienschmidt
Copy link
Member

#696 was merged!

@julienschmidt julienschmidt merged commit 4a0c3d7 into go-sql-driver:master Jan 10, 2018
@AlekSi AlekSi deleted the patch-1 branch January 25, 2018 09:15
bLamarche413 pushed a commit to bLamarche413/mysql that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants