Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow successful TravisCI runs in forks #639

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

jmhodges
Copy link
Contributor

Most forks won't be in goveralls and so this command in travis.yml was,
previously, failing and causing the build to fail.

Now, it doesn't!

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@jmhodges
Copy link
Contributor Author

Gentle ping!

@methane
Copy link
Member

methane commented Oct 16, 2017

I think it's very common issue and there should be official recommendation
or de-facto standard.

Is || exit 0 idiom is recommended officially? Or widely used?
Is there no better way?

@methane
Copy link
Member

methane commented Oct 16, 2017

Maybe, moving goveralls to after_script?

https://docs.travis-ci.com/user/customizing-the-build/#Breaking-the-Build

The exit code of after_success, after_failure, after_script and subsequent stages do not affect the build result. However, if one of these stages times out, the build is marked as a failure.

@jmhodges
Copy link
Contributor Author

Okay, did that

@julienschmidt
Copy link
Member

@jmhodges if you implemented this change already, please push your commits so that we can merge the fix.

@julienschmidt julienschmidt added this to the v1.4 milestone Oct 17, 2017
Most forks won't be in goveralls and so this command in travis.yml was,
previously, failing and causing the build to fail.

Now, it doesn't!
@jmhodges
Copy link
Contributor Author

Ah, word, mispushed earlier. It's up here now.

@julienschmidt julienschmidt merged commit fade210 into go-sql-driver:master Oct 17, 2017
@jmhodges
Copy link
Contributor Author

Thanks!

bLamarche413 pushed a commit to bLamarche413/mysql that referenced this pull request Mar 23, 2018
Most forks won't be in goveralls and so this command in travis.yml was,
previously, failing and causing the build to fail.

Now, it doesn't!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants