fix: remove last 0 byte for mysql_old_password when password is empty #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I create a user with
mysql_old_password
as auth plugin but without password, and use this user to login(refer this test: https://github.com/rainingmaster/go-mysql-test), it will failed, as my test here, and report Error 1043: Bad handshake.After my investigation, I have compared the login data from mysql client(which is successful), I found client do not need to send the last
0' byte for the auth switch, if we append last
0` byte even empty password, the hand shake will be broken.For
maradb:5.5
tomaradb:10.3
, it wont response auth switch by response ok straightly.Checklist