Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pvc values usage in PersistentVolumeClaim #19

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

zhekazuev
Copy link
Contributor

@zhekazuev zhekazuev commented Jul 7, 2023

Issue

Incorrect paths to models.persistence.pvc values in the PersistentVolumeClaim template cause PersistentVolumeClaim to generate an error and fail to start the pod.

Ref: #16

Changes:

  • use correct path to pvc values - .Values.models.persistence.pvc;
  • update some templates - use with instead of if for: annotations and storageClassName;
  • improve range operator for accessModes - do not generate accessModes when value is empty.
  • delete newline for labes and space traling {{- for that

How to check

# should not generate pvc template and not add the name of PVC in Deployment
helm template test charts/local-ai/ --set models.persistence.pvc.enabled=false

# should generate pvc template and add the name of PVC in Deployment
helm template test charts/local-ai/ --set models.persistence.pvc.enabled=true

@zhekazuev zhekazuev marked this pull request as ready for review July 7, 2023 17:21
@zhekazuev zhekazuev changed the title fix: update pvc values usage in PersistentVolumeClaim fix: update pvc values usage in PersistentVolumeClaim - close https://github.com/go-skynet/helm-charts/issues/16 Jul 7, 2023
@zhekazuev zhekazuev changed the title fix: update pvc values usage in PersistentVolumeClaim - close https://github.com/go-skynet/helm-charts/issues/16 fix: update pvc values usage in PersistentVolumeClaim - close #16 Jul 7, 2023
@zhekazuev zhekazuev changed the title fix: update pvc values usage in PersistentVolumeClaim - close #16 fix: update pvc values usage in PersistentVolumeClaim Jul 7, 2023
Signed-off-by: Eugene Zuev <[email protected]>
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mudler mudler merged commit e19930c into go-skynet:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants