Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to provide PDF archives for bookmarks by directly downloading the file.
Notable changes
ArchiverDomain
ArchiverDomain
initializes a list of archivers that try to match the content type, if it does, that archiver is used. If an error is raised, the next archiver is used and so on.PDFArchiver
: Just downloads the file.WARCArchiver
as a "catch all" (current default)bookmark.archiver
(warc
/pdf
) andarchive_path
.archive_path != ""
Pending
archive_path
for existing bookmarks: iterate over the bookmarks, check if the archive exists and set the path and thearchiver
towarc
.Closes #929