Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-ext): use same save logic as the api #518

Merged
merged 3 commits into from
Oct 15, 2022
Merged

fix(api-ext): use same save logic as the api #518

merged 3 commits into from
Oct 15, 2022

Conversation

fmartingr
Copy link
Member

  • Modified the extension API to use the same save flow as the regular API, by generating the bookmark first and trying to archive it later. This will result in a stored bookmark even if the archiving fails.
  • Switched the session priority, now the header has more priority than the cookie, witch should be the default, since the webserver sends the cookie and the extension requires the session anyway.
  • Fixed the DB.GetBookmark method by handling the sql.ErrNoRows silently (since it already exposes a bool).

Fixes #517

@fmartingr fmartingr self-assigned this Oct 15, 2022
@fmartingr fmartingr marked this pull request as ready for review October 15, 2022 11:07
@fmartingr fmartingr merged commit d1f0ce8 into master Oct 15, 2022
@fmartingr fmartingr deleted the issue-517 branch October 15, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add bookmarks using shiori git
1 participant