fix err in keyword searching #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulb
commented
Oct 9, 2022
| @@ -223,7 +223,9 @@ func (db *PGDatabase) GetBookmarks(ctx context.Context, opts GetBookmarksOptions | |||
| if opts.Keyword != "" { | |||
| query += ` AND ( | |||
| url LIKE :lkw OR | |||
| MATCH(title, excerpt, content) AGAINST (:kw IN BOOLEAN MODE) | |||
There was a problem hiding this comment.
It seems that MATCH ... AGAINST is a mysql syntax for text searching. In postgres, I don't find such simple way to implement text matching so I use LIKE multi times as a workround.
There was a problem hiding this comment.
Yeah, we need to implement FTS into PSQL, I need to take a look at #276 first in order to decide an engine.
|
Hey @hulb, as always, thank you for fixing this! Little by little we're making Shiori more stable and usable :) |
You're welcome.Glad to contribute :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #470 #477