Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go version for heroku #388

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Add Go version for heroku #388

merged 4 commits into from
Mar 1, 2022

Conversation

My6UoT9
Copy link
Contributor

@My6UoT9 My6UoT9 commented Feb 28, 2022

Heroku requires an extra line so it knows which go version to use.
https://github.com/heroku/heroku-buildpack-go#go-module-specifics

@fmartingr
Copy link
Member

Hey @My6UoT9, thanks for the contribution! I'm merging this right away.

I may put a "Deploy to heroku" button in the readme as well, that still exists, right?

@fmartingr fmartingr merged commit b68092c into go-shiori:master Mar 1, 2022
@My6UoT9
Copy link
Contributor Author

My6UoT9 commented Mar 1, 2022

I think it does yes, I am sorry I should have tested more extensively.
Sofar it seems I loose all data when heroku starts again, I have to check how to have data persisted.

@fmartingr
Copy link
Member

I think it does yes, I am sorry I should have tested more extensively. Sofar it seems I loose all data when heroku starts again, I have to check how to have data persisted.

Yeah, I assume that using SQLite the database will be created on the dyno directly, which is ephemeral by default. If I recall correctly, in order to add heroku support properly an app.json needs to be created in the root of the repository. So far your change may be useful for people that want to take a quick peek at Shiori, they can deploy it to heroku and test it there even though a more permanent solution will require more work.

@My6UoT9
Copy link
Contributor Author

My6UoT9 commented Mar 1, 2022

Hm yes, maybe add a warning :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants