Optimize the size of the built image #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can further reduce by packing with UPX: https://gitlab.com/equalos/skaffold/-/blob/master/shiori/docker/shiori/Dockerfile |
good idea :) |
pyunramura
added a commit
to pyunramura/shiori
that referenced
this pull request
Jan 26, 2022
fmartingr
force-pushed
the
master
branch
4 times, most recently
from
d1ffd75
to
d70a8f2
Compare
|
Hey @soulteary, thanks a lot for the contribution! There has been a reworks of some parts of the application and another contributor already reduced the container image quite a lot. I think this PR is a bit redundant now, but if you still feel like there's room for a smaller image size, please open a new PR and we will take a look a it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #278 , thanks @n8225
This PR only optimized the final docker image size, eg: