Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET endpoint to extension API #297

Closed
wants to merge 2 commits into from

Conversation

hursey013
Copy link

@hursey013 hursey013 commented Feb 3, 2021

Allows checking if a bookmark already exists from the extension by using:

https://shiori.domain/api/bookmarks/ext?value={{encoded URL}}

This paves the way to allow the extension to see if a bookmark exists without relying on a local browser bookmark folder.

pyunramura added a commit to pyunramura/shiori that referenced this pull request Jan 26, 2022
@fmartingr
Copy link
Member

Hey @hursey013 , thanks for the PR!

A few notes before moving forward:

  • Rebase the changes from latest master, since the session duration was already implemented by where is the shiori docker database? How to backup and restore #446 the changes in the assets and login files are no longer required.
  • We can use status codes instead of payloads. So, instead of returning a bool we can just use the 200 and 204 status codes.

Please let me know if you're (or not) interested in moving this forward so I can prioritise it myself.

@stale
Copy link

stale bot commented Oct 17, 2022

This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the tag:stale label Oct 17, 2022
@stale stale bot closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants