Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve first time usage, password-less #290

Closed
wants to merge 2 commits into from

Conversation

cauerego
Copy link

this will needs to be better documented, but at least it ain't freeze users from testing and using the software. plus it'll work great for my use case, "achoz". 😘

this will needs to be better documented, but at least it ain't freeze users from testing and using the software. plus it'll work great for my use case, "achoz". 😘
for easier first access while keeping it compatible with logout without new accounts and without modifying too much of the rest of the code.
@cauerego
Copy link
Author

added a commit there that improves it a bit further. now it should be just pressing login button, nothing else needed, for first use case.

@fmartingr
Copy link
Member

Hey @cauerego, thanks for the contribution! Sadly I believe this is out of scope, for various reasons:

  • I plan to remove the default "account" (which isn't an account) since all user related data belongs in the database.
  • In the future, a default user could be automatically populated by a migration
  • Also in the future, the CLI could have account management to easily create the first user account
  • Having this that way is removing a required check in the frontend.
  • In order to have a proper "single-user" shiori, we need to properly discuss it in Feature request: Single user mode (avoid login screen) #352

Honestly I'm sad closing PRs for contributors (and even more for first timers) but we need to think what to implement here first in order for it to be easy and useful for everyone.

@cauerego
Copy link
Author

@fmartingr sounds like a perfect decision to me.

the whole point of this was to actually remove users from shiori to begin with. i guess it just wasn't sure clear at first. 🤣

yes, let's discuss it there on #352. 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants