-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve API consistency #184
Conversation
Hi @disposedtrolley, thanks for the PR. Looks good. Could you rebase on master/fix the conflicts? |
91e1c33
to
b2686f5
Compare
@deanishe all fixed up now! |
d1ffd75
to
d70a8f2
Compare
Hello from the present @disposedtrolley, thanks for your contribution! How do you feel on continuing working on this? Don't worry if you wont, I can follow up on this issue myself! |
Hey @fmartingr, happy 2022! I'm a little worried about introducing breaking changes to the API actually; I felt this was appropriate in 2019, but I'm sure the community and ecosystem has grown much since then, and I want to make sure we keep any downstream consumers happy. What do you think? |
It makes sense. But sooner or later we may need to version the API, with a proper session persistence via JWT, unifying endpoints with the extension and so on. When I reach that point I will make sure to influence myself with your submission :) |
b2686f5
to
ecc7f52
Compare
@fmartingr I've fixed the merge conflicts by re-doing my changes from scratch. I've also dropped the commit that was formatting errors from panics into a nice response body. I'd like to remove the body entirely at some point as I don't think we should be exposing internal error messages to consumers. Let me know what you think! |
Hey @disposedtrolley, good work! I'm going to mark this change for 1.6.0 for now. After that I need to start creating task for a proper
You're totally right. (Relates to #236) |
Hey @disposedtrolley, if you can fix those conflicts we can move forward with this to test it before the next release :) |
Hello again!
This PR improves some of the resource APIs to be more aligned with REST best practices. It:
1
in the body to return a204 No Content
status with an empty body insteadPUT /api/tag
endpoint to/api/tags
I've also generated a new bundle for the frontend since some of the API changes required changes to the associated JS files.