Skip to content

Commit

Permalink
sqlite: remove unneeded LEFT JOIN to improve performance (#387)
Browse files Browse the repository at this point in the history
* sqlite: remove unneeded LEFT JOIN to improve performance

* Fix handling join clause in GetBookmarks

* Revert changes in GetBookmarks
  • Loading branch information
tungel committed Mar 10, 2022
1 parent b68092c commit ca3cc11
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion internal/database/sqlite.go
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ func (db *SQLiteDatabase) GetBookmarksCount(opts GetBookmarksOptions) (int, erro
// Create initial query
query := `SELECT COUNT(b.id)
FROM bookmark b
LEFT JOIN bookmark_content bc ON bc.docid = b.id
WHERE 1`

// Add where clause
Expand Down

0 comments on commit ca3cc11

Please sign in to comment.