Suggestion to change json parser in order to improve performance

[ghost]

Instead of using standard encoding/json, maybe use another like https://github.com/json-iterator/go

[jeevatkm]

Thank you for your suggestion. I will have a look.

[jeevatkm]

@ZandorZ I have done my analysis.

json-iterator supports all three compliant methods

• Marshal(v interface{}) ([]byte, error)
• Unmarshal(data []byte, v interface{}) error
• MarshalIndent(v interface{}, prefix, indent string) ([]byte, error)

There are other two candid libraries are available:

ffjson supports two compliant methods

• Marshal(v interface{}) ([]byte, error)
• Unmarshal(data []byte, v interface{}) error

easyjson but this one is doesn't support drop-in replacement, so out-of-choice.

So, following is my design choice/approach:

• By default use standard encoding/json package in resty
• Expose option to register developer choice of JSON library into resty. Basically resty client will have two new fields
  • JSONMarshal func(v interface{}) ([]byte, error)
  • JSONUnmarshal func(data []byte, v interface{}) error

For example developer can register like this-

// For default client
resty.DefaultClient.JSONMarshal = jsoniter.Marshal
resty.DefaultClient.JSONUnmarshal = jsoniter.Unmarshal

// For custom client
myclient := resty.New()
myclient.JSONMarshal = jsoniter.Marshal
myclient.JSONUnmarshal = jsoniter.Unmarshal

I will give it try on the implementation and will post the outcome.

Do you have any suggestions?

[jeevatkm]

I have implemented above mentioned design e621018, it is not yet merged to master.

[ghost]

@jeevatkm Good idea!

[jeevatkm]

Merging e621018 into master.

[jeevatkm]

Merged to master