Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep method UseRandomizedTTL thread safe #100

Open
wants to merge 1 commit into
base: v9
Choose a base branch
from

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Sep 9, 2023

Hello

this method is not thread safe. I am not sure what was the intent with such method BTW

also, the LFU cache is already thread safe, it is not need add a mutex on the wrapper.

if it is possible remove this method at some point, there is no need for mutex

@peczenyj peczenyj mentioned this pull request Sep 9, 2023
@peczenyj
Copy link
Contributor Author

Hello

I continue some refactors and create the pull request #101 where I convert this method to a functional option

you can close this PR if you want @vmihailenco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant