Updated linting #46
Merged
Updated linting #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fredbi
commented
Dec 4, 2023
- updated golangci lint rules
- updated github actions
- updated dependencies
- fixed dead links/badges in README
- relinted (tests and docstrings)
- removed unexecuted integration tests
* updated golangci lint rules * updated github actions * update required go version to go 1.19, in line with other go-openapi packages * updated dependencies * adapted YAMLToJSON tests to yaml/v3 (with new version of go-openapi/swag) * fixed dead links/badges in README * relinted (tests and docstrings) * removed unexecuted integration tests Signed-off-by: Frederic BIDON <[email protected]>
youyuanwu
reviewed
Dec 5, 2023
| ) | ||
|
|
||
| func TestPathLoaderIssue(t *testing.T) { | ||
| swaggerFile := "fixtures/json/resources/pathLoaderIssue.json" |
There was a problem hiding this comment.
@youyuanwu
Integration tests are not executed by CI, so this is essentially almost dead code.
The maintainance of the dependencies for this separate module is going to be a pain on the long run.
I believe we have better ways with Github actions to run intgration tests without adding cross-dependencies like this. Working on that part.
youyuanwu
approved these changes
Dec 5, 2023
Signed-off-by: Frederic BIDON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.